Find the problem in shell script postinstall.sh

[lgillis]

An error has occurred during the installation of Java I2P 2.8.0. The attached screenshot shows the problem. Do you recognize the problem? Want to fix the bug?

Type: image/webp, size: 26.05 KB, link: Java I2P postinstall Cannot determine operating system type.webp

https://git.idk.i2p/i2p-hackers/i2p.i2p/-/blob/master/installer/resources/postinstall.sh

[zzz]

Thanks for the report.
Fixed in 37a71fd15fa31feecb16537cc769b359e3b08c3b to be 2.8.0-6-rc

[lgillis]

I didn't mean you, but ok. I hope it didn't take 15 minutes? The script now only contains 23 notes instead of 24 and still contains 11 warnings. Maybe someone with a big broom will come along after all? (I already feel sick when I see half a dozen rm -f/rf in such a mess).

Have a nice weekend.

Code: Select all

   16   4 warning  e-f-b    shellcheck [SC2164]: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
   26   8 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   28  23 warning  e-f-b    shellcheck [SC2166]: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
   30   4 note     e-f-b    shellcheck [SC2129]: Consider using { cmd1; cmd2; } >> file instead of individual redirects.
   36   8 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   37   7 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   43  13 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   43  13 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   43  19 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   45  15 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   45  15 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   45  21 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   47  15 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   47  15 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   47  21 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   49  15 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   49  15 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   49  21 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   51  15 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   51  15 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   51  21 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   53  15 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   53  15 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   53  21 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   65  15 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
   65  15 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
   65  21 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
   92  25 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
  104  23 warning  e-f-b    shellcheck [SC2193]: The arguments to this comparison can never be equal. Make sure your syntax is correct.
  105   7 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
  113   7 note     e-f-b    shellcheck [SC2006]: Use $(...) notation instead of legacy backticks `...`.
  113   7 warning  e-f-b    shellcheck [SC2046]: Quote this to prevent word splitting.
  113  13 note     e-f-b    shellcheck [SC2086]: Double quote to prevent globbing and word splitting.
  115  10 note     e-f-b    shellcheck [SC2035]: Use ./*glob* or -- *glob* so names with dashes won't become options.

[zzz]

There's no fix that takes less than 15 minutes, at least for me. I have to reproduce it, find it, fix it, retest, verify, check it in, update the history and roadmap, and reply.

[lgillis]

He really didn't understand my reference. What a pity. Now we're standing there, deeply affected. One of two developers who are still visibly active and I'm annoying them here.

There is one colon too many in the site-updater.sh file, I have corrected this. You can download the file and compare if you like.

https://git.idk.i2p/i2p-hackers/i2p.www/-/blob/master/site-updater.sh?ref_type=heads 19, 66

http://sharefile.i2p/file/92/9272923c3a85adef6ee162871258fc2d068779425d68385ad9305eab30439b76/site-updater_lgillis.sh